fix vgmstream-cli invocation for POSIX #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux and macOS, vgmstream-cli uses the POSIX
getoptfunction, which enforces a specific options standard; one where it parses options before non-options. However, it is my understanding that on Windows, vgmstream-cli uses the glibcgetoptfunction, which is different in that it is flexible in what positions it can parse options passed to the program in.Because of this, the tool fails on POSIX systems when waiting for vgmstream-cli to exit cleanly. vgmstream-cli throws the error
input files must go after options. Simply swapping the arguments around completely takes care of the discrepancy, as it appeases the syntax of bothgetopttypes.I tested this PR on both Windows (x64) and macOS (arm64) and there are no issues with decryption on either of them.