Add SDL3 support #3339
Add SDL3 support #3339
Conversation
github-actions
bot
added
Window/Scenes
Audio
Building
Documentation
Wii
Settings
Ghabry
removed
Window/Scenes
Documentation
Wii
Settings
|
Also have to fix the CMake presets. Will add presets for at least SDL3 and SDL2 (if applicable) and a "default" preset where we can use a recommended default. Since inception of the presets this feature did not improve, so it will be more cartesian product preset generation (hooray). |
A default triplet is kept for all platforms, usually selects SDL2 and can be bumped to newer versions later.
Is unsupported since a while.
|
This is now finished. It still uses SDL2 by default as I don't want to get SDL3 up and working right now for all our ports. Too much work. Also isn't tested as much as SDL2 yet. |
| } | ||
|
|
||
| Sdl2Audio::~Sdl2Audio() { | ||
| SDL_CloseAudioDevice(audio_dev_id); |
There was a problem hiding this comment.
On Arch they replaced sdl2 with sdl2-compat (SDL2 ontop of SDL3). This call aborts now with "Invalid Pointer" (exactly the same reason why I disabled that line in the SDL3 backend)
|
Found the related issue: libsdl-org/sdl2-compat#313
|
This is now required by SDL3 because SDL_Quit deletes the audio state. Added it to all SDL version because it is also triggered by the compat-libraries.
My last change before xmas is still compiling, so just opening a PR here for it.
Depends on the Wii SDL2 branch