Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up test noise #830

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix: clean up test noise #830

merged 2 commits into from
Dec 6, 2023

Conversation

stephenjwatkins
Copy link
Member

πŸ“ Changes

  • cleans up test noise
  • uses correct alignment prop on Stepper
  • silences console errors on tests that throw

clean test output:

image

βœ… Checklist

  • Unit tests are written and passing
  • Changeset is added

@@ -30,11 +30,11 @@ export type StepperProps = {
};

/**
* The `<Stepper />` component is used to indicate progress as the user goes
* The `<Stepper />` component is used to indicate progress as the user goes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must have been a prettier update between then and now

@stephenjwatkins stephenjwatkins marked this pull request as ready for review December 5, 2023 19:40
Copy link
Contributor

@kevinalexliu kevinalexliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stephenjwatkins stephenjwatkins merged commit 5d3ad6c into main Dec 6, 2023
2 checks passed
@stephenjwatkins stephenjwatkins deleted the fix-test-noise branch December 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants