Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude SSRProvider from build #1174

Merged
merged 4 commits into from
May 8, 2024
Merged

fix: exclude SSRProvider from build #1174

merged 4 commits into from
May 8, 2024

Conversation

stephenjwatkins
Copy link
Member

@stephenjwatkins stephenjwatkins commented May 8, 2024 •
edited
Loading

📝 Changes

  • Remove @react-aria/ssr from being embedded in the build to allow for apps to have a singleton instance of SSRProvider. Addresses When server rendering, you must wrap your application in an <SSRProvider> to ensure consistent ids are generated between the client and server. warnings.

✅ Checklist

  • Visuals are complete and match Figma
  • Code is complete and in accordance with our style guide
  • Design and theme tokens are audited for any relevant changes
  • Unit tests are written and passing
  • TSDoc is written or updated for any component API surface area
  • Stories in Storybook accompany any relevant component changes
  • Ensure no accessibility violations are reported in Storybook
  • Specs and documentation are up-to-date
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

@stephenjwatkins stephenjwatkins marked this pull request as ready for review May 8, 2024 19:35
OskiTheCoder
OskiTheCoder approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@OskiTheCoder OskiTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenjwatkins stephenjwatkins merged commit 45cfcef into main May 8, 2024
3 checks passed
@stephenjwatkins stephenjwatkins deleted the fix_ssr_provider branch May 8, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranebo ranebo ranebo approved these changes

@OskiTheCoder OskiTheCoder OskiTheCoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenjwatkins @ranebo @OskiTheCoder