Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two minor fixes for Cube #55

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Two minor fixes for Cube #55

merged 3 commits into from
Dec 15, 2023

Conversation

The9Cat
Copy link
Contributor

@The9Cat The9Cat commented Dec 11, 2023

  • 'byPlanes' should not be defined inside Cuda block
  • missing header

@The9Cat The9Cat changed the title Two minor fixes for CUbe Two minor fixes for Cube Dec 11, 2023
michael-petersen
michael-petersen reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@michael-petersen michael-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other fixes look great, no concerns beyond Cylinder.cc.

src/Cylinder.cc Show resolved Hide resolved
@michael-petersen michael-petersen merged commit 2c39ad3 into main Dec 15, 2023
0 of 8 checks passed
@michael-petersen michael-petersen deleted the CubeTest branch December 15, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-petersen michael-petersen michael-petersen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The9Cat @michael-petersen