Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Base64 Documentation #984

Open
rijesha opened this issue Dec 2, 2024 · 3 comments
Open

Update Base64 Documentation #984

rijesha opened this issue Dec 2, 2024 · 3 comments

Comments

@rijesha
Copy link

rijesha commented Dec 2, 2024

Hi John.
Very much appreciate the library. When you have time could you update the instructions for using base64?
https://www.etlcpp.com/base64.html
Thanks

@jwellbelove
Copy link
Contributor

In what way?
We're you looking for an example of every permutation of parameter types?

@rijesha
Copy link
Author

rijesha commented Dec 3, 2024

I'm wasn't sure how to implement base64 encoding because I did not know that there were built in permutations. When I used the latest release I got an error that base64::encode doesn't exist. I went through the code and saw that there is a new ibase64_encoder. I initially presumed I needed to implement an interface to do the base64 encoding. So then I ended up going to release 20.38.16 which still worked with the example code. I think I saw some of the permutations, but was not sure if they can be used in the same way as in the original example.

I think the instructions should mention that these permutations exist and in the example code instead of etl::base64::encode it should be etl::base64_/*permutation*/_encoder::encode or something like that.

@jwellbelove
Copy link
Contributor

OK, I understand now. I didn't realise that I had not updated the documentation to match the refactored base64 code in back in June 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants