-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow registry fields with initial_value to not error on not found in input data #365
base: development
Are you sure you want to change the base?
Allow registry fields with initial_value to not error on not found in input data #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jimmielin !
One testing request, but otherwise no notes! Excellent work on the somewhat confusing build cache updates.
test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks again @jimmielin
After this fix and #362 all regression tests should be able to run even without a PBL scheme.
|
Tag name (required for release branches):
Originator(s): @jimmielin (with extensive guidance from @peverwhee)
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Should enable CAM7 / CAM4 regression tests to run again despite no PBL scheme, if
pbuf_pblh
includes<initial_value>0.0_kind_phys</initial_value>
in registry.xml - separate PR will include this.Describe any changes made to build system:
vars_init_value
in generation of physics_inputs.F90 to record which variables have an<initial_value>
set inregistry.xml
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>
)If there are new failures (compared to the
test/existing-test-failures.txt
file),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: