Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the MUSICA library in CAM-SIMA #364

Draft
wants to merge 14 commits into
base: development
Choose a base branch
from

Conversation

boulderdaze
Copy link
Collaborator

@boulderdaze boulderdaze commented Feb 20, 2025

Tag name (required for release branches):
Originator(s): @boulderdaze

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

  • Build the MUSICA library in CAM-SIMA as part of the Create Terminator and Chapman chemistry configurations #321 to enable the full implementation of MICM and TUV.
  • Update the Dockerfiles to include a newer version of ESMF that is the same version used by Derecho, and update the contents to use MUSICA schemes.
  • Update the README instructions for downloading submodules.

Describe any changes made to build system:
Added functions to build musica in cime_config/buildlib

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do:

A       cime_config/atm_musica_config.py

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       .dockerignore
M       README.md
M       cime_config/buildlib
M       docker/Dockerfile
M       docker/Dockerfile.esmf
M       docker/Dockerfile.musica
M       src/physics/utils/musica_ccpp_dependencies.meta

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff? N/A

derecho/intel/aux_sima: N/A

derecho/gnu/aux_sima: N/A

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced: N/A

CAM-SIMA date used for the baseline comparison tests if different than latest:

@boulderdaze boulderdaze self-assigned this Feb 20, 2025
@boulderdaze boulderdaze changed the title 321 create config run musica Build the MUSICA library in CAM-SIMA Feb 20, 2025
@boulderdaze
Copy link
Collaborator Author

It's not shown in the file diff section, so I'm mentioning here that the following path in buildlib doens't exist. Although it's included in the Filepath, the actual directory is missing. This isn't an issue when building the MUSICA or other physics schemes, but I was curious as to why it's included despite not existing.

        # If using the CMEPS/NUOPC coupler, then add additional path:
        if case.get_value("COMP_INTERFACE") == "nuopc":
            paths.append(os.path.join(__CIMEROOT, "src", "drivers",
                                      "nuopc", "nuopc_cap_share"))
        # End if

@nusbaume
Copy link
Collaborator

Hi @boulderdaze, that code was leftover from an earlier version of CAM-SIMA where we had two different CESM coupling infrastructures and had to pick one each time. However, I think now it is just dead code, so feel free to remove it in your PR if you'd like. Thanks for catching it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants