Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini-PR: Cleanup in Ohm solver for readability #5675

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

roelof-groenewald
Copy link
Member

As said in the title, this is just a small PR to make the HybridPICSolveE kernels more readable.

Signed-off-by: roelof-groenewald <regroenewald@gmail.com>
@roelof-groenewald roelof-groenewald added the cleaning Clean code, improve readability label Feb 15, 2025
Signed-off-by: roelof-groenewald <regroenewald@gmail.com>
Signed-off-by: roelof-groenewald <regroenewald@gmail.com>
Copy link
Member

@clarkse clarkse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is much easier to follow now. Thanks for cleaning it up.

@ax3l ax3l added the component: fluid-ohm Related to the Ohm's law solver (with fluid electrons) label Feb 19, 2025
@ax3l ax3l merged commit e627b9c into ECP-WarpX:development Feb 19, 2025
37 checks passed
@roelof-groenewald roelof-groenewald deleted the hybrid_cleanup branch February 19, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability component: fluid-ohm Related to the Ohm's law solver (with fluid electrons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants