Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDash: fix variables in CTestConfig.cmake #5611

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Jan 28, 2025

Try using CTest module variables, instead of CTest script variables, given that we are not using a CTest script, to fix fields displayed in the CDash dashboard.

Examples of guidance from the official documentation (https://cmake.org/cmake/help/v3.24/manual/ctest.1.html):

Screenshot from 2025-01-28 11-04-12

Screenshot from 2025-01-28 11-08-45

However, this seems to be true for all other variables in CTestConfig.cmake. Should we try to update them all?

@EZoni EZoni added the component: tests Tests and CI label Jan 28, 2025
@EZoni EZoni requested a review from ax3l January 28, 2025 19:09
@ax3l ax3l self-assigned this Jan 29, 2025
@ax3l
Copy link
Member

ax3l commented Jan 29, 2025

Oh, interesting.

Or, we could use a site-specific ctest script, that way we can have a script for Azure, one for Perlmutter, etc...

@ax3l ax3l merged commit 0e1df84 into ECP-WarpX:development Jan 29, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants