From 83e31cc8ecc5532052090bf377e5b263dff10958 Mon Sep 17 00:00:00 2001 From: Alejandro Parcet Gonzalez Date: Wed, 29 Jan 2025 17:41:24 +0100 Subject: [PATCH 1/2] fix: dual layer select now works as expected Signed-off-by: Alejandro Parcet Gonzalez --- package.json | 2 +- src/renderer/modules/KeysTabs/LayersTab.tsx | 27 ++++++++++++++------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index a3c157ef9..eb6261192 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ }, "homepage": "https://github.com/Dygmalab/Bazecor", "engines": { - "node": "^20.13.1", + "node": "^20", "npm": ">=10.0.0" }, "devDependencies": { diff --git a/src/renderer/modules/KeysTabs/LayersTab.tsx b/src/renderer/modules/KeysTabs/LayersTab.tsx index cf143dc25..6c700c58f 100644 --- a/src/renderer/modules/KeysTabs/LayersTab.tsx +++ b/src/renderer/modules/KeysTabs/LayersTab.tsx @@ -2,6 +2,7 @@ import React, { useMemo, useState, useEffect, useCallback } from "react"; import { AnimatePresence, motion } from "framer-motion"; import { toast } from "react-toastify"; +// import log from "electron-log/renderer"; import { Button } from "@Renderer/components/atoms/Button"; import Heading from "@Renderer/components/atoms/Heading"; @@ -100,6 +101,17 @@ const LayersTab = ({ keyNumInternal = 0; } + const handleDual = (keyBase: number, layer?: number) => { + const layerItem = layer + ? findLayerType(undefined, activeLayerTab, layer) + : findLayerType(undefined, activeLayerTab, activeLayerNumber); + // log.info("checking layer item", layerItem, layerItem.keynum + keyBase); + if (layerItem && layerItem.type === "layerDual") { + onKeySelect(layerItem.keynum + keyBase); + setOpenKeysPopover(false); + } + }; + const handleLayer = (layerNumber: number) => { const layerItem = findLayerType(undefined, activeLayerTab, layerNumber); // console.log("Layer inside handle: ", layerItem); @@ -113,6 +125,8 @@ const LayersTab = ({ } if (layerItem && layerItem.type !== "layerDual") { onKeySelect(layerItem.keynum); + } else { + handleDual(keyCode.base, layerNumber); } }; @@ -122,14 +136,6 @@ const LayersTab = ({ onKeySelect(layerItem.keynum); }; - const handleDual = (keyBase: number) => { - const layerItem = findLayerType(undefined, activeLayerTab, activeLayerNumber); - if (layerItem && layerItem.type === "layerDual") { - onKeySelect(layerItem.keynum + keyBase); - setOpenKeysPopover(false); - } - }; - useEffect(() => { const layerItem = findLayerType(undefined, activeLayerTab, activeLayerNumber); if (macros && activeTab === "macro" && layerItem && triggerDeleteLastItem) { @@ -208,7 +214,10 @@ const LayersTab = ({ handleLayer(index + 1); }} selected={index + 1 === activeLayerNumber} - disabled={index > 7 && disableOneShotButtons && activeLayerTab === "layerShot"} + disabled={ + (index > 7 && disableOneShotButtons && activeLayerTab === "layerShot") || + (activeLayerTab === "layerDual" && index > 7) + } key={`buttonLayerID-${button.layer}`} className="h-9 aspect-square" > From 9eb9d55bd7d38b825841cd2292b7e9d462e721b4 Mon Sep 17 00:00:00 2001 From: Alejandro Parcet Gonzalez Date: Wed, 29 Jan 2025 17:44:04 +0100 Subject: [PATCH 2/2] fix: upped macos version to 13 Signed-off-by: Alejandro Parcet Gonzalez --- .github/workflows/release.yml | 4 ++-- .github/workflows/testing.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d3d002e38..5a1226f7e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -23,7 +23,7 @@ jobs: fail-fast: false matrix: include: - - os: macos-12 + - os: macos-13 - os: windows-2019 - os: ubuntu-20.04 steps: @@ -60,7 +60,7 @@ jobs: fail-fast: false matrix: include: - - os: macos-12 + - os: macos-13 - os: windows-2019 - os: ubuntu-20.04 diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 090b0eb7d..22b4a2baf 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -20,7 +20,7 @@ jobs: fail-fast: false matrix: include: - - os: macos-12 + - os: macos-13 - os: windows-2019 - os: ubuntu-20.04