Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matchit benchmarks to v0.8.6 #232

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update matchit benchmarks to v0.8.6 #232

merged 1 commit into from
Jan 7, 2025

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Jan 7, 2025

Uses the routes with literals as paths now instead.

Turns out some of the old routes were wrong too 😅

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #232 will degrade performances by 94.56%

Comparing matchit-v0.8.6 (fefb616) with main (9f06dec)

Summary

❌ 8 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main matchit-v0.8.6 Change
matchit benchmarks/actix-router 172.6 µs 2,413.2 µs -92.85%
matchit benchmarks/matchit 8.2 µs 89.1 µs -90.78%
matchit benchmarks/ntex-router 29.5 µs 384.9 µs -92.33%
matchit benchmarks/path-tree 10.6 µs 117.5 µs -91.01%
matchit benchmarks/route-recognizer 35.3 µs 574.5 µs -93.85%
matchit benchmarks/routefinder 50.2 µs 921.8 µs -94.56%
matchit benchmarks/wayfind 10.9 µs 100.9 µs -89.21%
matchit benchmarks/xitca-router 8.6 µs 104.8 µs -91.82%

@CathalMullan CathalMullan merged commit 3e973f0 into main Jan 7, 2025
7 checks passed
@CathalMullan CathalMullan deleted the matchit-v0.8.6 branch January 7, 2025 15:35
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
src/node/search.rs 67.43% <ø> (ø)

CathalMullan added a commit that referenced this pull request Jan 7, 2025
Update matchit benchmarks to v0.8.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant