Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing experiments #220

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Hashing experiments #220

merged 2 commits into from
Dec 12, 2024

Conversation

CathalMullan
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
src/lib.rs 67.79% <ø> (ø)
src/routers.rs 93.47% <100.00%> (-1.76%) ⬇️
src/routers/path.rs 95.97% <100.00%> (+0.41%) ⬆️

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #220 will degrade performances by 9.36%

Comparing no-hash (3a663ef) with main (5dc9b16)

Summary

❌ 2 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main no-hash Change
matchit benchmarks/wayfind 12.6 µs 13.3 µs -5.1%
path-tree benchmarks/wayfind 65.5 µs 72.3 µs -9.36%

@CathalMullan CathalMullan marked this pull request as ready for review December 12, 2024 18:32
@CathalMullan CathalMullan merged commit c2c829f into main Dec 12, 2024
8 checks passed
@CathalMullan CathalMullan deleted the no-hash branch December 12, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant