Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak release profile. #213

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Tweak release profile. #213

merged 1 commit into from
Nov 15, 2024

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Nov 15, 2024

No improvement natively, but performs better inside the VM.

path-tree benchmarks/path-tree benchmarks/wayfind
                        time:   [5.0600 µs 5.0699 µs 5.0828 µs]
                        change: [-6.9033% -6.6107% -6.3174%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  3 (3.00%) high severe
path-tree benchmarks/path-tree benchmarks/actix-router
                        time:   [187.47 µs 187.82 µs 188.20 µs]
                        change: [-17.174% -16.167% -15.051%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) high mild
  5 (5.00%) high severe
path-tree benchmarks/path-tree benchmarks/matchit
                        time:   [9.5411 µs 9.5532 µs 9.5658 µs]
                        change: [-20.179% -19.354% -18.761%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  6 (6.00%) high severe
path-tree benchmarks/path-tree benchmarks/ntex-router
                        time:   [35.458 µs 35.529 µs 35.623 µs]
                        change: [+2.0924% +2.7236% +3.5443%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  4 (4.00%) high mild
  2 (2.00%) high severe
path-tree benchmarks/path-tree benchmarks/path-tree
                        time:   [8.4842 µs 8.4942 µs 8.5048 µs]
                        change: [-11.373% -10.827% -10.345%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  3 (3.00%) high mild
  5 (5.00%) high severe
path-tree benchmarks/path-tree benchmarks/route-recognizer
                        time:   [67.237 µs 67.379 µs 67.542 µs]
                        change: [-19.891% -19.500% -19.098%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  6 (6.00%) high mild
  5 (5.00%) high severe
path-tree benchmarks/path-tree benchmarks/routefinder
                        time:   [85.861 µs 85.957 µs 86.068 µs]
                        change: [-21.068% -20.803% -20.542%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild
path-tree benchmarks/path-tree benchmarks/xitca-router
                        time:   [11.722 µs 11.738 µs 11.754 µs]
                        change: [-4.5687% -4.2041% -3.8165%] (p = 0.00 < 0.05)
                        Performance has improved.

ntex-router the only outlier.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
README.md 62.74% <ø> (ø)

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #213 will degrade performances by 12.52%

Comparing release (647bdfa) with main (ce73838)

Summary

⚡ 10 improvements
❌ 1 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main release Change
gitlab insert benchmarks/wayfind 19.2 ms 18.3 ms +5.19%
matchit benchmarks/path-tree 14.1 µs 13 µs +8.05%
matchit benchmarks/route-recognizer 42.5 µs 37.7 µs +12.77%
matchit benchmarks/routefinder 54.5 µs 50.2 µs +8.41%
matchit benchmarks/xitca-router 12.9 µs 11.4 µs +13.48%
path-tree benchmarks/actix-router 1,012.6 µs 957.7 µs +5.74%
path-tree benchmarks/ntex-router 245.6 µs 280.7 µs -12.52%
path-tree benchmarks/path-tree 89.6 µs 81.4 µs +10.11%
path-tree benchmarks/route-recognizer 592.3 µs 531.1 µs +11.54%
path-tree benchmarks/routefinder 558.9 µs 481.5 µs +16.09%
path-tree benchmarks/wayfind 68.9 µs 64.8 µs +6.28%

@CathalMullan CathalMullan merged commit 9cde77e into main Nov 15, 2024
9 checks passed
@CathalMullan CathalMullan deleted the release branch November 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant