Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend path search struct to work as request builder. #212

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Nov 15, 2024

For some reason - this results in 2.5% slower benchmarks locally.

Want to at least understand why before merging.

UPDATE: With the new benchmark env, this is no slower than before. Good!

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
README.md 66.66% 0 Missing and 4 partials ⚠️
src/request.rs 73.33% 3 Missing and 1 partial ⚠️
src/errors/request.rs 95.83% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/errors/routable.rs 95.83% <ø> (ø)
src/router.rs 93.96% <100.00%> (+0.09%) ⬆️
src/errors/request.rs 95.83% <95.83%> (ø)
README.md 67.79% <66.66%> (+5.05%) ⬆️
src/request.rs 73.33% <73.33%> (ø)

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #212 will not alter performance

Comparing builder (ac7d638) with main (ae95bdf)

Summary

✅ 19 untouched benchmarks

@CathalMullan CathalMullan merged commit 490e34c into main Nov 15, 2024
8 of 9 checks passed
@CathalMullan CathalMullan deleted the builder branch November 15, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant