Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same-branch matching #149

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Sep 9, 2024

Solve it stupidly first, then worry about performance.
We might need to introduce a 3rd state to quick_dynamic?

EDIT: No, solution is quite simple actually. Shouldn't impact performance that much. Won't appear on benchmarks, since none of our benchmarks measure inline search speed.

Let's add more tests too.

@CathalMullan CathalMullan linked an issue Sep 9, 2024 that may be closed by this pull request
@CathalMullan CathalMullan force-pushed the 148-router-fails-to-route-to-more-specific-options branch from 7a921ad to 4615430 Compare September 9, 2024 15:12
@CathalMullan CathalMullan force-pushed the 148-router-fails-to-route-to-more-specific-options branch from 4615430 to 391a88d Compare September 9, 2024 15:12
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #149 will not alter performance

Comparing 148-router-fails-to-route-to-more-specific-options (517c1ee) with main (0a3ceb0)

Summary

✅ 16 untouched benchmarks

@CathalMullan CathalMullan marked this pull request as ready for review September 10, 2024 12:45
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/node/search.rs 87.87% 1 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
src/node/search.rs 78.71% <87.87%> (+0.60%) ⬆️

@CathalMullan CathalMullan force-pushed the 148-router-fails-to-route-to-more-specific-options branch from e914b37 to 58c2d8d Compare September 10, 2024 13:17
@CathalMullan CathalMullan force-pushed the 148-router-fails-to-route-to-more-specific-options branch from 58c2d8d to 517c1ee Compare September 10, 2024 13:17
@CathalMullan CathalMullan merged commit cd64023 into main Sep 10, 2024
6 of 7 checks passed
@CathalMullan CathalMullan deleted the 148-router-fails-to-route-to-more-specific-options branch September 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router fails to route to more specific options
1 participant