New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure 'path' and 'route' terms are used consistently #146

Merged

CathalMullan merged 1 commit into main from 145-ensure-we-use-terms-path-and-route-correctly

Sep 7, 2024

Contributor

CathalMullan commented Sep 7, 2024

No description provided.

CathalMullan linked an issue

that may be closed by this pull request

Ensure we use terms 'path' and 'route' correctly #145

Closed

codecov bot commented Sep 7, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 96.05263% with 12 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/errors/insert.rs	81.25%	3 Missing ⚠️
src/node/delete.rs	83.33%	3 Missing ⚠️
src/router.rs	50.00%	0 Missing and 3 partials ⚠️
src/parser.rs	98.74%	2 Missing ⚠️
src/errors/path.rs	75.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/decode.rs	`96.87% <100.00%> (ø)`
src/errors/delete.rs	`86.66% <100.00%> (ø)`
src/errors/encoding.rs	`100.00% <100.00%> (ø)`
src/errors/route.rs	`100.00% <100.00%> (ø)`
src/lib.rs	`55.55% <ø> (ø)`
src/node/insert.rs	`91.75% <100.00%> (+0.11%)`	⬆️
src/node/search.rs	`78.11% <ø> (ø)`
src/path.rs	`100.00% <100.00%> (ø)`
src/errors/path.rs	`37.50% <75.00%> (-62.50%)`	⬇️
src/parser.rs	`98.59% <98.74%> (ø)`
... and 3 more

codspeed-hq bot commented Sep 7, 2024 •

edited

Loading

CodSpeed Performance Report

Merging #146 will not alter performance

_{Comparing 145-ensure-we-use-terms-path-and-route-correctly (5f5d037) with main (77ad7a1)}

Summary

✅ 16 untouched benchmarks


          Ensure 'path' and 'route' terms are used consistently

5f5d037

CathalMullan force-pushed the 145-ensure-we-use-terms-path-and-route-correctly branch from a37d136 to 5f5d037 Compare

September 7, 2024 22:13

CathalMullan merged commit 0a3ceb0 into main

7 checks passed

CathalMullan deleted the 145-ensure-we-use-terms-path-and-route-correctly branch

September 7, 2024 22:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet