Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OCI registry example #142

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Aug 30, 2024

Ok, all the fluff is complete.
Now to actually implement the endpoints.

EDIT: Ok, the OCI pull tests pass now. I think we should just leave it at that. Tidy the code, add comments, proper errors, etc.

Don't want to tweak this code too much over time. Project should really stay static, outside of wayfind changes. So important we get this right initially.

@CathalMullan CathalMullan linked an issue Aug 30, 2024 that may be closed by this pull request
Copy link

codspeed-hq bot commented Aug 30, 2024

CodSpeed Performance Report

Merging #142 will not alter performance

Comparing 141-create-a-most-substantial-hyper-example (c04be60) with main (8b6626a)

Summary

✅ 16 untouched benchmarks

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
src/node/search.rs 78.11% <ø> (ø)

@CathalMullan CathalMullan force-pushed the 141-create-a-most-substantial-hyper-example branch 7 times, most recently from b59fff8 to 72af8af Compare August 31, 2024 15:18
@CathalMullan CathalMullan force-pushed the 141-create-a-most-substantial-hyper-example branch 5 times, most recently from b6b27ec to 5eefdac Compare September 2, 2024 20:37
@CathalMullan CathalMullan changed the title Update hyper example to implement OCI registry Introduce OCI registry example Sep 2, 2024
@CathalMullan CathalMullan force-pushed the 141-create-a-most-substantial-hyper-example branch 9 times, most recently from cb13488 to ea291b8 Compare September 4, 2024 01:29
@CathalMullan CathalMullan marked this pull request as ready for review September 4, 2024 01:38
@CathalMullan CathalMullan force-pushed the 141-create-a-most-substantial-hyper-example branch from fc48706 to 0610611 Compare September 4, 2024 15:49
@CathalMullan CathalMullan force-pushed the 141-create-a-most-substantial-hyper-example branch from 0610611 to c04be60 Compare September 4, 2024 15:51
@CathalMullan CathalMullan merged commit 04bc935 into main Sep 4, 2024
7 checks passed
@CathalMullan CathalMullan deleted the 141-create-a-most-substantial-hyper-example branch September 4, 2024 16:01
CathalMullan added a commit that referenced this pull request Sep 4, 2024
…l-hyper-example

Introduce OCI registry example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a more substantial hyper example
1 participant