feat: fix backend and deserialize object_info correctly for querying … #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarleanu
force-pushed
the
feat/backend-api-fixes
branch
from
70c9ffa to
f7a3d02
Compare
vgarleanu
commented
May 30, 2024
vgarleanu
commented
May 30, 2024
IGI-111
reviewed
May 31, 2024
IGI-111
reviewed
Jun 6, 2024
| @@ -50,6 +70,8 @@ impl Mediator { | |||
|
|
|||
| populate_available_nodes(&mut model); | |||
|
|
|||
| model.spawn_client(tx.clone()); | |||
There was a problem hiding this comment.
Why isn't this part of Backend::new?
Comment on lines
+234
to
+237
| let _ = value.parse().map(|x| state.set_int(x)); | ||
| } | ||
| TY_FLOAT => { | ||
| let _ = value.parse().map(|x| state.set_float(x)); |
There was a problem hiding this comment.
use if-let instead of map if you don't care about the resulting value.
| _ => {} | ||
| } | ||
| } | ||
| Render => { |
There was a problem hiding this comment.
This needs a better name, it's too easy to confuse with UI rendering.
Comment on lines
+252
to
+253
| println!("\n"); | ||
| println!("{:#?}", &wf); |
There was a problem hiding this comment.
Suggested change
| println!("\n"); | |
| println!("{:#?}", &wf); | |
| println!("\n\n{:#?}", &wf); |
| ui.global::<ui::NodeLogic>().on_move_node({ | ||
| move |node_idx, x, y| { | ||
| tx.send(Event::SetNodePosition(node_idx as usize, x, y)) | ||
| // TODO: Make me a macro! |
| @@ -0,0 +1 @@ | |||
|
|
|||
| @@ -0,0 +1,4 @@ | |||
| imports_granularity = "Item" | |||
There was a problem hiding this comment.
Hot garbage. Use this and no less.
Suggested change
| imports_granularity = "Item" | |
| imports_granularity = "Crate" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…available nodes