Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass line and column numbers to expression evaluation requests #195

Closed
chrishamm opened this issue Jan 12, 2024 · 1 comment
Closed

Pass line and column numbers to expression evaluation requests #195

chrishamm opened this issue Jan 12, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@chrishamm
Copy link
Contributor

At present, G-code exceptions from RRF may be inaccurate because the line number may not be set at the time a G-code exception is thrown. To fix this, DSF needs to pass the line number and ideally column of the expression start to evaluation requests. Also, I figure statements like echo line may be off. This is not the case if line is used in G-codes like M118 P{line} since binary G-codes already provide the line number.

@chrishamm chrishamm added the enhancement New feature or request label Jan 12, 2024
@chrishamm chrishamm added this to the Version 3.6 milestone Jan 12, 2024
@chrishamm chrishamm self-assigned this Jan 12, 2024
@chrishamm
Copy link
Contributor Author

See #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant