Feature/save test finishing time epmdj 10980 #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adata-key-value-EPMDJ-10972' into feature/save-test-finishing-time-EPMDJ-10980
…ishing-time-EPMDJ-10980 # Conflicts: # admin-writer/src/main/kotlin/com/epam/drill/admin/writer/rawdata/table/TestLaunchTable.kt
RomanDavlyatshin
requested changes
Feb 5, 2025
| @@ -0,0 +1,2 @@ | |||
| ALTER TABLE raw_data.test_launches | |||
| ADD COLUMN IF NOT EXISTS duration BIGINT DEFAULT NULL; | |||
There was a problem hiding this comment.
BIGINT is an overkill, integer is sufficient
https://www.postgresql.org/docs/current/datatype-numeric.html
There was a problem hiding this comment.
I agree that for milliseconds integer will be enough for a test execution time. It's just that the duration of time is usually measured in a long type in Java and a cast to int type will be required
| @@ -192,7 +191,7 @@ class RawDataServiceImpl( | |||
| id = sessionPayload.id, | |||
| groupId = sessionPayload.groupId, | |||
| testTaskId = sessionPayload.testTaskId, | |||
| startedAt = sessionPayload.startedAt.toLocalDateTime(TimeZone.UTC).toJavaLocalDateTime() | |||
| startedAt = sessionPayload.startedAt.toLocalDateTime(TimeZone.currentSystemDefault()).toJavaLocalDateTime() | |||
There was a problem hiding this comment.
What's the motivation for this change?
refactor: return back UTC timezone for startedAt field
|
RomanDavlyatshin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.