Github workflows

[DrewThomasson]

Continuing this from this conversation here
#203

[DrewThomasson]

Hey @dawilk

I'm looking at modifying this and I'm just making sure that I did this right here.

having it push a docker image if it the new version release passes all my tests and if its a new version release

Although there might be a better way of doing this....

61ad9c3

[DrewThomasson]

Or perhaps I should make it] {Build and push the docker if it passes all the tests} {add the latest version number to it each time to update the latest small docker release}

by small I mean without the xtts models baked into it and whatnot hm

or perhaps I should just do the full baked in.....

I am unsure about how to go about this properly 😓

[dawilk]

I thought I had replied to this already. I looked at that commit linked above. It will not do what you are assuming it will there. The events (workflow_run and release) are mutually exclusive; you cannot have a job condition that is looking for context information from each event.
The workflow when it runs will be running because of one event or the other (or a separate run for each).

If the goal is to make sure tests are run before building and pushing a new image, I would suggest running the tests on PRs, and require passing tests to merge. Then, build and push on push to main [and/or release and/or workflow_dispatch, if you want other triggers].

There's a lot of ways to have GItHub do the build and push, but which configuration you use depends on what you want the code change process and controls to look like.

[DrewThomasson]

I'll try building the flow your suggesting and hit you up if I run into any issues

Thanks for clarifying it btw cause your right, that commit wasn't working as I wanted