Missed edge case in gifted node design #577

Author: riteshsamala

www/js/model.js

@@ -1078,7 +1078,13 @@ define([
 				if( (nodeStatus === "correct" && score === 0 && completeness) || (nodeStatus === "correct" && score === 1 && tweaked && completeness))
 					nodeStatus = "perfect";
 				if(gifted){
-					nodeStatus = "gifted-"+nodeStatus;
+					//if a gifted node turns out to be not a perfect node, ungift it and let user solve it and regular badges follow
+					if(nodeStatus == "perfect"){
+						nodeStatus = "gifted-"+nodeStatus;
+					}
+					else{
+						this.unGiftNode(id);
+					}
 				}
 				return nodeStatus;
 			},
@@ -1326,6 +1332,9 @@ define([
 			isGifted: function(id){
 				return this.getNode(id).gifted ? true : false;
 			},
+			unGiftNode: function(id){
+				this.getNode(id).gifted = false;
+			},
 			getCorrectAnswer : function(/*string*/ studentID, /*string*/ part){
 				var id = this.getAuthoredID(studentID);
 				var node = obj.authored.getNode(id);