Inconsistent state with multiple yellow nodes #576

Author: riteshsamala

www/js/model.js

@@ -1403,6 +1403,11 @@ define([
 					update("schemas");
 					update("entity");
 					update("equation");
+					//in case slots are not yet corrected, return incorrect even if the equation status is demo, refer to topomath issue "Inconsistent state with multiple yellow nodes #576"
+					var slotsCorrected = this.areSlotsDemo(studentID);
+					if(bestStatus == "demo" && this.getStatus(studentID,"equation").status == "demo" && !slotsCorrected){
+						bestStatus = "incorrect";
+					}
 				}
 				if(bestStatus == "partial"){
 					bestStatus = "incorrect";
@@ -1484,6 +1489,20 @@ define([
 				var entityValid = entityStatusObj.status == "correct" || entityStatusObj.status == "demo";
 				return schemaValid && entityValid;
 			},
+			areSlotsDemo: function(nodeID){
+				var ret = false;
+				var statusObj = this.getNode(nodeID).status;
+				Object.keys(statusObj).some(function(key){
+					if(key!= "schemas" && key!= "entity" && key!= "description" && key!= "equation"){
+						console.log(key);
+						if(statusObj[key] == "demo"){
+							ret = true;
+							return true;
+						}
+					}
+				});
+				return ret;
+			},
 			getGreenScore: function(problemConditions){
 				//returns the percentage of the greens or stars from all the user solved nodes so far
 				//nodeDen is the denominator the score being computed. It comprises of all the nodes student attempted so far (which exludes given nodes)