Add draft of resources in Client and Server #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EduardoLR10
commented
Dec 16, 2024
•
EduardoLR10
commented
- Closes Make resources #60
Co-authored-by: Lemos <dudulr10@gmail.com> Co-authored-by: Magueta <maguetamarcos@gmail.com>
schonfinkel
reviewed
Mar 18, 2025
| @@ -1,5 +1,5 @@ | |||
| CREATE TABLE player.record( | |||
| username VARCHAR(32) NOT NULL, | |||
| username TEXT NOT NULL, | |||
There was a problem hiding this comment.
@MMagueta do you think it makes sense to create a domain type for usernames? we could also add a check constraint as well, but IDK if postgres likes CHECKs in primary keys.
| ); | ||
| END IF; | ||
|
|
||
| -- These records are used as function arguments | ||
| IF to_regtype('map.input') IS NULL THEN | ||
| CREATE TYPE map.input AS ( | ||
| map_name VARCHAR(18), | ||
| map_name TEXT, |
There was a problem hiding this comment.
Same here, although we control the map names, unlike the usernames.
| ); | ||
|
|
||
| CREATE TABLE character.instance( | ||
| name VARCHAR(18) NOT NULL, | ||
| name TEXT NOT NULL, |
There was a problem hiding this comment.
Same here, either a domain type or a check constraint, since this will be user input.
Comment on lines
+132
to
+149
| old_quantity := NULL; | ||
| SELECT quantity INTO old_quantity FROM character.inventory | ||
| WHERE name = new_name | ||
| AND username = new_username | ||
| AND e_mail = new_e_mail | ||
| AND item_name = new_item_name; | ||
| IF old_quantity IS NOT NULL | ||
| THEN | ||
| UPDATE character.inventory | ||
| SET quantity = old_quantity + new_quantity | ||
| WHERE name = new_name | ||
| AND username = new_username | ||
| AND e_mail = new_e_mail | ||
| AND item_name = new_item_name; | ||
| ELSE | ||
| INSERT INTO character.inventory(name, e_mail, username, quantity, item_name) | ||
| VALUES (new_name, new_e_mail, new_username, new_quantity, new_item_name); | ||
| END IF; |
There was a problem hiding this comment.
@EduardoLR10 @MMagueta @z-silver Wouldn't an upsert with a where clause + EXCLUDED replace the need for an extra SELECT query, be easy to understand and also more performant?
INSERT INTO character.inventory(name, e_mail, username, quantity, item_name)
VALUES (new_name, new_e_mail, new_username, new_quantity, new_item_name)
ON CONFLICT (name, e_mail, username, item_name)
DO UPDATE SET
-- EXCLUDED is an alias to the row that is conflicting
-- https://www.postgresql.org/docs/17/sql-insert.html
-- so this line is basically the sum of old + new
quantity = EXCLUDED.quantity + character.inventory.quantity,
WHERE character.inventory.quantity IS NOT NULL;here's a draft of mine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.