Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightfunnels domain-connect template #569

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

f-amine
Copy link
Contributor

@f-amine f-amine commented Nov 12, 2024

Description

This pull request adds a Domain Connect template for LightFunnels, enabling users to easily connect their custom domain to their LightFunnels shop. The template includes CNAME records for the www subdomain and custom subdomains, simplifying the domain configuration process for LightFunnels users

Type of change

Please mark options that are relevant.

  • New template

How Has This Been Tested?

Please mark the following checks done

Example variable values

v1: aaa

Copy link

Linter OK:

Linter result for lightfunnels.com.website.json

@kerolasa kerolasa self-requested a review November 13, 2024 09:46
@kerolasa
Copy link
Collaborator

The template looks good to me. Please notice that if you want to onboard the template to Cloudflare you also need syncPubKeyDomain, but that might not be in plans so this side note is not very relevant.

@f-amine
Copy link
Contributor Author

f-amine commented Nov 13, 2024

bKeyDomai

Just trying to use godaddy for now we might plan to add cloudflare later so thank you for the notice

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pawel-kow pawel-kow added this pull request to the merge queue Nov 14, 2024
Merged via the queue into Domain-Connect:master with commit 328e55f Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants