Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify any default templates, use the default button text #2

Open
niemyjski opened this issue Mar 20, 2015 · 1 comment
Open

Comments

@niemyjski
Copy link

I think that by default you shouldn't mess with the button content. If anything provide an easy way to specify a loading icon (with position).

@DocX
Copy link
Owner

DocX commented Mar 30, 2015

Thank you for comment. My philosophy is to keep default to match majority
of use cases and then, if needed, to provide ways to override it.

I think intention of current default is to have simple way to make ready to
use button without repeating myself. Since you're the first one who wants
to change it, I'm keeping it as it now.

You are of course free to make patch that provide override, I'll be happy
to merge it.
Dne 20. 3. 2015 17:11 "Blake Niemyjski" notifications@github.com
napsal(a):

I think that by default you shouldn't mess with the button content. If
anything provide an easy way to specify a loading icon (with position).


Reply to this email directly or view it on GitHub
#2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants