Skip to content

Fix styling for awesome page search bar and ToC #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juls0730
Copy link
Contributor

@juls0730 juls0730 commented Mar 28, 2025

Fixes styling for the awesome page search bar, it now matches the nav search bar, is much more accessible and looks good on dark themes. If this gets merged, it supersedes #452 so it should be closed.

Old awesome page:
old-awesome

New awesome page:
new-awesome

Old ToC (specifically on pages with many sections), you cannot scroll to see all of the sections:
Screenshot_20250327_213813

New ToC:
Screenshot_20250327_213845

@juls0730 juls0730 changed the title Fix styling for awesome and ToC and fix ToC links Fix styling for awesome page search bar and ToC and fix ToC links Mar 28, 2025
@juls0730
Copy link
Contributor Author

juls0730 commented Mar 28, 2025

My ToC fixes dont fix a number of links on https://dioxuslabs.com/blog/release-060 however, though, all the links it doesnt fix are becuase it's cut off due to the use of backticks in the title, a fix is in the works

@juls0730
Copy link
Contributor Author

juls0730 commented Mar 28, 2025

every ToC link on the v0.6 blog page now

  1. Links to the correct section
  2. Accurately reflects the header

🎉

@juls0730
Copy link
Contributor Author

perhaps I should bisect out the stylistic changes and the bug fix into separate prs

@juls0730
Copy link
Contributor Author

it's always git add

@juls0730 juls0730 reopened this Mar 28, 2025
@juls0730 juls0730 changed the title Fix styling for awesome page search bar and ToC and fix ToC links Fix styling for awesome page search bar and ToC Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant