REMOVE SPROCKETS + SUPPORT VITE #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move assets to src folder and package it as @digitalnz/plug and publish it to com - update installer to include required js files - import trix and milligram as node package - drop support to sprockets and introduce vite support
hapiben
commented
Jul 24, 2024
| copy_file 'plug.vite.js', 'app/frontend/entrypoints/plug.js' | ||
| end | ||
|
|
||
| def add_plug_package |
There was a problem hiding this comment.
This adds a package called @digitalnz/plug to the host app during the installation via rails g plug:install command.
hapiben
commented
Jul 24, 2024
Comment on lines
+2
to
+5
| @import 'trix/dist/trix'; | ||
| @import 'trix-overrides'; | ||
|
|
||
| @import 'milligram'; |
There was a problem hiding this comment.
Milligram and Trix are imported via npm package now instead of the minified version.
There was a problem hiding this comment.
That's much better!
paul-mesnilgrente
approved these changes
Jul 24, 2024
Comment on lines
+2
to
+5
| @import 'trix/dist/trix'; | ||
| @import 'trix-overrides'; | ||
|
|
||
| @import 'milligram'; |
There was a problem hiding this comment.
That's much better!
|
super nit: Do you think you could change the title of this MR to mention that it's for Plug? I feel like we might have trouble finding this MR down the line without it :) otherwise it looks really good. Nice! |
chigginsboost
approved these changes
Jul 24, 2024
richardmatthewsdev
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
plug.jsentrypoint and addPlugpackage.Plugassets into a npm package.