Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gulp-Sass] Improper filtering of partials when #compiled is placed after compilation. #3

Open
MarkL4YG opened this issue Nov 12, 2018 · 1 comment
Labels
enhancement New feature or request Foreign cause Behavior is caused in conjunction with another project which is likely to be the cause.

Comments

@MarkL4YG
Copy link
Contributor

MarkL4YG commented Nov 12, 2018

Since v1.0.1/v1.0.2, we declare files as compiled when they are piped through #reportCompiled().
As this is desired to be done AFTER Sass compilation so Sass errors do not mark a file as compiled, we have trouble with partials:

When piped to gulp-sass, they are consumed and removed from the stream.

  if (path.basename(file.path).indexOf('_') === 0) {
    return cb();
  }

That causes them to be never considered as compiled as they are no longer in the stream.


We need a solution to this issue.
A discussion with the gulp-sass maintainers about this may also be required.
Until then, placing the #reportCompile() before the sass call will work around that issue.

@MarkL4YG MarkL4YG added the enhancement New feature or request label Nov 12, 2018
@MarkL4YG MarkL4YG added the Foreign cause Behavior is caused in conjunction with another project which is likely to be the cause. label Nov 19, 2018
@MarkL4YG MarkL4YG changed the title Partials always recompiled. [Gulp-Sass] Partials always recompiled when placed after compilation. Nov 19, 2018
@MarkL4YG
Copy link
Contributor Author

MarkL4YG commented Nov 19, 2018

It is also necessary to evaluate whether or not this even is an issue as gulp-sass will not invoke compilation anyways due to the same code part.
Displaying a one-time heads-up message may be enough to make users aware about the improper filtering of partials.
Tracking and dependency checks however should not be impacted by this.

@MarkL4YG MarkL4YG changed the title [Gulp-Sass] Partials always recompiled when placed after compilation. [Gulp-Sass] Improper filtering of partials when #compiled is placed after compilation. Nov 19, 2018
MarkL4YG added a commit that referenced this issue Nov 19, 2018
* Related to: #3
* Only displayed once per runtime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Foreign cause Behavior is caused in conjunction with another project which is likely to be the cause.
Projects
None yet
Development

No branches or pull requests

1 participant