Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ophyd_async due to pydantic #683

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Pin ophyd_async due to pydantic #683

merged 2 commits into from
Jul 18, 2024

Conversation

DominicOram
Copy link
Contributor

See #679

Instructions to reviewer on how to test:

  1. Re-install dodal and confirm dependencies are happy, particularly we're still on pydantic<2.0

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (from running the tests) that dodal is not actually compatible with ophyd-async 0.3.1 (e.g. soft_signal_r_and_setter doesn't take units as used by i22 dcm in this version...), should probably remove the lower bound or at least increase it to the version which works

@DominicOram DominicOram requested a review from d-perl July 17, 2024 15:27
Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@DominicOram DominicOram merged commit 1eb1c5c into main Jul 18, 2024
11 checks passed
@DominicOram DominicOram deleted the pin_ophyd_async_pydantic branch July 18, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants