-
Notifications
You must be signed in to change notification settings - Fork 0
add BinaryApp app type #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 42.55% 44.48% +1.92%
==========================================
Files 23 24 +1
Lines 860 906 +46
==========================================
+ Hits 366 403 +37
- Misses 494 503 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -96,3 +102,39 @@ def _create_shell_file(self, app: ShellApp, module: Module) -> None: | |||
executable=True, | |||
create_parents=True, | |||
) | |||
|
|||
ALL_READ_EXECUTE_PERMISSIONS = 0o555 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module level constants are normally defined at the top of the file, just under the imports.
Adds a new type of app which downloads a standalone binary, checks its hash and places it in the entrypoints folder.
Also adds the argocd module to demo_configuration in order to demonstrate the feature.