-
Notifications
You must be signed in to change notification settings - Fork 0
Add the host_binaries feature #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dce5cec
to
6f4c2ca
Compare
1fd92f8
to
f5cf111
Compare
f5cf111
to
6a87e17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
===========================================
+ Coverage 42.55% 75.14% +32.58%
===========================================
Files 23 23
Lines 860 865 +5
===========================================
+ Hits 366 650 +284
+ Misses 494 215 -279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
set -xe | ||
|
||
THIS_DIR=$(realpath $(dirname ${0})) | ||
SAMPLES_DIR=${THIS_DIR}/samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by 'samples'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples is sample output from the sample (demo) definitions. I guess I'm just copying how I did things in ibek here - happy to use a different name but what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this type of testing can be called:
- Snapshot testing
- Golden Master testing
- Comparison testing
Since we already use 'snapshot' to refer to something else, perhaps we can use 'comparison_master' instead of 'samples', and put a brief description in the generation script, including the name of the test?
Also rename the test to:
test_compare_demo_configuration_output_to_comparison_master()
?
A bit of a mouthful, but at least it's explicit. You could drop 'configuration', too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you reword the VSCode Task description for the comparison_master generation.
aff25af
to
ec1c3d2
Compare
<<<<<<< HEAD | ||
======= | ||
|
||
>>>>>>> ce3367b (add test for demo_configuration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be removed
Adds an option to the apptainer type app.
This allows you to list a set of binaries that should be discovered on the host using path and then mounted into the apptainer at /usr/bin.
Also adds: