Don't allow players to choose monster/NPC name (#38)

DevelopersPL · Jan 8, 2018 · bb944ad · bb944ad
1 parent 1bc82eb
commit bb944ad
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/DevAAC/routes/players.php b/DevAAC/routes/players.php
@@ -514,6 +514,23 @@
     if($player)
         throw new InputErrorException('Player with this name already exists.', 400);
 
+    $forbiddenPlayerNames = [];
+
+    if (file_exists(TFS_ROOT . '/data/monster/monsters.xml')) {
+        $xml = simplexml_load_file(TFS_ROOT . '/data/monster/monsters.xml');
+        if (property_exists($xml, 'monster'))
+            $forbiddenPlayerNames = array_map('strtolower', array_column(xml2array($xml)['monster'], 'name'));
+    }
+
+    foreach (glob(TFS_ROOT . '/data/npc/*.xml') as $npcFile) {
+        $xml = simplexml_load_file($npcFile);
+        if (property_exists($xml->attributes(), 'name'))
+            array_push($forbiddenPlayerNames, strtolower(xml2array($xml->attributes()->name)[0]));
+    }
+
+    if( in_array(strtolower($req->getAPIParam('name')), $forbiddenPlayerNames) )
+        throw new InputErrorException('This player name is forbidden.', 400);
+
     $player = new Player(
         array(
             'name' => ucwords(strtolower($req->getAPIParam('name'))),