[Move] Fully Implement Uproar

[innerthunder]

What are the changes the user will see?

Uproar is now fully implemented.

Why am I making these changes?

📈

What are the changes from a developer perspective?

• Added the new battler tag UproarTag which inherits from MoveLockTag to implement Uproar's execution and sleep-preventing effects
• Uproar has 2 new attributes:
  • An AddBattlerTagAttr to add the aforementioned uproar tag onto the user
  • A MessageHeaderAttr to play "{pokemon} is making an uproar!" at the start of the turn when the user's uproar is in effect.
• Torment no longer interrupts any moves while the afflicted Pokemon is under the effects of a MoveLockTag. With this, Torment's edgeCase is removed.

Screenshots/Videos

WIP

How to test the changes?

npm run test uproar

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?

• Are all unit tests still passing? (npm run test:silent)
  • Have I created new automated tests (npm run test:create) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (dark and light)?

Are there any localization additions or changes? If so:

• Has a locales PR been created on the locales repo?
  • If so, please leave a link to it here: [Move][EN] Uproar poketernity-locales#34
• [?] Has the translation team been contacted for proofreading/translation?

[PigeonBar]

One final Frenzy check to change to MoveLockTagTypes:

poketernity/src/phases/check-switch-phase.ts

Lines 61 to 68 in 52916fa

	// ...or if any player Pokemon has an effect that prevents the checked Pokemon from switching
	if (
	pokemon.getTag(BattlerTagType.FRENZY)
	|| pokemon.isTrapped()
	|| globalScene.getPlayerField().some((p) => p.getTag(BattlerTagType.COMMANDED))
	) {
	return this.end();
	}

[PigeonBar]

Every new battler tag needs to be added to this list:

poketernity/src/data/move-attrs/add-battler-tag-attr.ts

Lines 70 to 71 in 52916fa

	getTagTargetBenefitScore(): number {
	switch (this.tagType) {

[MokaStitcher]

The uproar never stops if the wave finishes before it expires. It will also always fail in the next wave, resulting in an infinite loop

Steps to reproduce

 STARTING_LEVEL_OVERRIDE: 50,
 MOVESET_OVERRIDE: MoveId.UPROAR,
 ENEMY_MOVESET_OVERRIDE: MoveId.SPLASH,

• start a run
• use uproar
• go to the next wave

[MokaStitcher]

this gives pokemonNameWithAffix but the text expects just pokemonName

[innerthunder]

The uproar never stops if the wave finishes before it expires. It will also always fail in the next wave, resulting in an infinite loop

Steps to reproduce

 STARTING_LEVEL_OVERRIDE: 50,
 MOVESET_OVERRIDE: MoveId.UPROAR,
 ENEMY_MOVESET_OVERRIDE: MoveId.SPLASH,

• start a run
• use uproar
• go to the next wave

This seems to be an issue with frenzy moves as well... As far as I can tell it's related to MoveLockTag trying to resolve the target of the next queued move immediately after using the move. Random target selection only considers battler indexes with active Pokemon at the time, so all moves queued afterward have an empty targets array.

I'll put this in draft and make another PR with a fix since the issue isn't exclusive to Uproar