Skip to content
This repository has been archived by the owner on Dec 28, 2024. It is now read-only.

Commit

Permalink
Update CRAN comments with 1.6.0 test results
Browse files Browse the repository at this point in the history
  • Loading branch information
DesiQuintans committed Feb 21, 2019
1 parent 9c33fb0 commit d60ae0e
Showing 1 changed file with 8 additions and 18 deletions.
26 changes: 8 additions & 18 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,33 +1,23 @@
## Resubmission

This is a resubmission. I have made these changes based on your feedback:

- Added a lib argument to shelf() so that users can define a library folder.
- Added lib_paths(), which wraps .libPaths() and offers automatic folder creation.
- Wrapped examples in \donttest{} instead of commenting them out.
- Removed function names from DESCRIPTION field.

Other comments:

- You suggested that maybe the 'lib' arg could be passed through install_github() down
to install.packages(), but unfortunately not.

## Test environments

- Local Windows 7 64-bit install, R 3.5.2
- win-builder R-devel
- win-builder R-current (3.5.0)
- Local Windows 7 64-bit install, R 3.5.0
- win-builder R-current
- R-hub (Windows Server 2008 R2 SP1, R-devel)
- R-hub (Fedora Linux, R-devel)



## R CMD check results

There were no ERRORs or WARNINGs or NOTEs for the local R version that I tested.

win-builder (R-devel and R 3.5.0) produced no ERRORs or WARNINGs.
There were no ERRORs or WARNINGs or NOTEs for win-builder (R-devel and R 3.5.2).

win-builder produced 1 NOTE ("checking CRAN incoming feasibility").
There were no ERRORs or WARNINGs or NOTEs for R-hub (R-devel on Windows and Fedora Linux).


## Reverse dependencies

This is a new release, so there are no reverse dependencies.
None.

0 comments on commit d60ae0e

Please sign in to comment.