Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cyclic forcing support #2081

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add cyclic forcing support #2081

wants to merge 1 commit into from

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Feb 20, 2025

Fixes #153.

Notes:

  • With timeseries which are extrapolated in a periodic manner, the first and last data values must be validated to be the same. For linear interpolations this ensures continuity, and for constant interpolation this value would be otherwise ignored.
  • Time periods like years and months do not always have the same length, so this can get out of sync when these time periods are repeated. This should at least be documented well, and might need a follow-up issue.

@SouthEndMusic SouthEndMusic marked this pull request as draft February 20, 2025 12:15
@SouthEndMusic SouthEndMusic changed the title Add test model with cyclic forcing Add cyclic forcing support Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclic forcing
1 participant