Update to OteraEngine v1.1 #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the newline option, either CRLF or LF works. This leaves out the other default options and shortens the paths.
|
So this is just an update of Otera, with the new default config, but resulting in the same codegen diff (at least so on linux)? LGTM if you have tested the codegen on Windows as well. |
evetion
approved these changes
Feb 13, 2025
|
Yes indeed, I tested locally and it produces no diff. This mostly serves to verify to the OteraEngine developer that the fix for our bug report helped, and clean it up a little. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the newline option, either CRLF or LF works.
This leaves out the other default options and shortens the paths.
Better fix than #2054.