Bommelerwaard test model #2056

SouthEndMusic · 2025-02-12T19:30:57Z

Fixes #1936.

Notes:

I had to remove the truth states with "U" and "D" as we no longer support these (also removed this from the docs)
We no longer support ManningResistance connecting to LevelBoundary so I converted one ManningResistance to LinearResistance (node 29)
Also updated the Link table in the docs (usage.md) as this still mentioned node types
I had to refactor handling sources for allocation a bit because this model hits an edge (link) case I hadn't considered yet

SouthEndMusic · 2025-02-12T19:33:59Z

The model looks like this:

SouthEndMusic added 2 commits February 12, 2025 17:05

script Bommelerwaard model

d2ab6ee

Merge branch 'main' into bommelerwaard_test_model

1ca2699

SouthEndMusic marked this pull request as draft February 12, 2025 19:31

SouthEndMusic added 5 commits February 18, 2025 09:28

Single source of truth for sources in allocation init

b692746

Fix python tests

f529e0f

Fix the Julia tests

06fb6e8

Remove print statement

f324901

Fix stability problem in Bommelerwaard model

8abca67

SouthEndMusic marked this pull request as ready for review February 18, 2025 12:15

Merge branch 'main' into bommelerwaard_test_model

2ca0657

SouthEndMusic requested a review from visr February 18, 2025 12:16

Merge branch 'main' into bommelerwaard_test_model

53af5a1

visr approved these changes Feb 20, 2025

View reviewed changes

Add condition_id to new model

28c57b6

visr merged commit 5b2fd47 into main Feb 21, 2025
24 of 25 checks passed

visr deleted the bommelerwaard_test_model branch February 21, 2025 08:34

Provide feedback