-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sablier updates #12815
Sablier updates #12815
Conversation
refactor: reorder keys alphabetically in sablier refactor: rename "config" object to "contracts" refactor: rename "sablier" to "sablier-legacy" refactor: rename "sablier-v2" to "sablier-lockup"
Can you please merge this PR at the same with DefiLlama/defillama-server#8909, to avoid any downtime? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is hard to tell, is there any logic change other than moving around code & renaming folders?
We will change the name, but renaming folders actually break our system
Hey @g1nt0ki thanks for merging the PRs/.
No, but as per the other PR (DefiLlama/defillama-server#8909 (comment)), we've renamed our product. Renaming the folders would keep them in sync with the new product names. If it's too much of a hassle, happy to stick with I see that the following URLs all return 404 now: |
hi @PaulRBerg sorry, missed the comment about PR in server repo, give it a few hours. Feel like this is a bug with new listings (or renaming protocol in your case), it should fix itself |
Alright, thank you! |
Hey @g1nt0ki, I see that the However, I am getting 404 not found errors for the Would it be possible to set redirects from |
hi, we should add a redirect, unfortunately we dont have that setup atm. |
Made a few changes to the Sablier adapters.
sablier-v2
tosablier-lockup
sablier
tosablier-legacy