Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sablier updates #12815

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Sablier updates #12815

merged 2 commits into from
Dec 23, 2024

Conversation

PaulRBerg
Copy link
Contributor

Made a few changes to the Sablier adapters.

  • Renamed sablier-v2 to sablier-lockup
  • Renamed sablier to sablier-legacy

refactor: reorder keys alphabetically in sablier
refactor: rename "config" object to "contracts"
refactor: rename "sablier" to "sablier-legacy"
refactor: rename "sablier-v2" to "sablier-lockup"
@PaulRBerg
Copy link
Contributor Author

Can you please merge this PR at the same with DefiLlama/defillama-server#8909, to avoid any downtime?

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is hard to tell, is there any logic change other than moving around code & renaming folders?

We will change the name, but renaming folders actually break our system

@g1nt0ki g1nt0ki self-assigned this Dec 22, 2024
@realdealshaman realdealshaman merged commit 3b195b0 into DefiLlama:main Dec 23, 2024
1 check passed
@PaulRBerg PaulRBerg deleted the sablier-updates branch December 23, 2024 11:55
@PaulRBerg
Copy link
Contributor Author

Hey @g1nt0ki thanks for merging the PRs/.

Is there any logic change other than moving around code & renaming folders?

No, but as per the other PR (DefiLlama/defillama-server#8909 (comment)), we've renamed our product. Renaming the folders would keep them in sync with the new product names.

If it's too much of a hassle, happy to stick with sablier and sablier-v2, though in that case, I'd like to add a comment in the JavaScript code to explain the folder names.

I see that the following URLs all return 404 now:

@g1nt0ki
Copy link
Member

g1nt0ki commented Dec 23, 2024

hi @PaulRBerg sorry, missed the comment about PR in server repo, give it a few hours. Feel like this is a bug with new listings (or renaming protocol in your case), it should fix itself

@PaulRBerg
Copy link
Contributor Author

Alright, thank you!

@PaulRBerg
Copy link
Contributor Author

Hey @g1nt0ki, I see that the /sablier-legacy and the /sablier-lockup links work correctly. Thanks very much for that!

However, I am getting 404 not found errors for the /sablier-v1 and /sablier-v2 links.

Would it be possible to set redirects from /sablier-v1 to /sablier-legacy, and from to /sablier-v2 to sablier-lockup, pretty please?

@g1nt0ki
Copy link
Member

g1nt0ki commented Feb 5, 2025

Hey @g1nt0ki, I see that the /sablier-legacy and the /sablier-lockup links work correctly. Thanks very much for that!

However, I am getting 404 not found errors for the /sablier-v1 and /sablier-v2 links.

Would it be possible to set redirects from /sablier-v1 to /sablier-legacy, and from to /sablier-v2 to sablier-lockup, pretty please?

hi, we should add a redirect, unfortunately we dont have that setup atm.

@PaulRBerg
Copy link
Contributor Author

Alright, thanks for confirming @g1nt0ki — opened a feature request here: #13396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants