Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster prepping should be done outside model forward #64

Open
drinkingkazu opened this issue Jan 29, 2020 · 0 comments
Open

cluster prepping should be done outside model forward #64

drinkingkazu opened this issue Jan 29, 2020 · 0 comments
Assignees
@francois-drielsma
Labels
enhancement New feature or request

Comments

@drinkingkazu
Copy link
Contributor

Recent gnn model (in @francois-drielsma fork) has cluster prepping inside the forward function. This causes unnecessary data movement (cpu<=>gpu) and hence should be done beforehand (like in a parser).
@drinkingkazu drinkingkazu added the enhancement New feature or request label Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francois-drielsma francois-drielsma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drinkingkazu @francois-drielsma