Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrapper handling of empty entries within a batch #116

Open
francois-drielsma opened this issue Jul 19, 2022 · 0 comments
Open

Unwrapper handling of empty entries within a batch #116

francois-drielsma opened this issue Jul 19, 2022 · 0 comments
Assignees

Comments

@francois-drielsma
Copy link
Collaborator

francois-drielsma commented Jul 19, 2022

Two things I observed:

  • With batch_size=1 and an empty particle_graph, the unwrapper crashes when buidling the unwrap_map
  • With batch_size=2 and a particle_graph with only one batch_id, the unwrapper returns a single entry for that data product

It looks to me that if a data product, say particle_graph, has no corresponding row for a particular batch ID, the number of np.arrays returned by the unwrapper may be different from other data products that do, which is undesirable. If the batch_size is 16, we should have 16 objects per data product returned, even if they are empty. One way to do this is to use the batch_idx_max to resize outputs instead of appending them. Correct me if I am misreading the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants