Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply wrap-and-sort -at by default #239

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

n-peugnet
Copy link
Contributor

The Go team currently recommends the flags --wrap-always --trailing-comma [1] which translates to -at, so dh-make-golang should use this flag combination by default.

[1] https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-debian-control

The Go team currently recommends the flags --wrap-always --trailing-comma [1]
which translates to -at, so dh-make-golang should use this flag combination by default.

[1] https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-debian-control
@ottok
Copy link
Contributor

ottok commented Jan 7, 2025

This https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-debian-control is very old. I think most people nowadays would recommend -ast, which is also what upstream wrap-and-sort maintainers seem to plan to make the future default for the whole tool, and what debputy reformat already uses.

So I am in favor of merging this but with -ast as the default.

@ottok
Copy link
Contributor

ottok commented Jan 19, 2025

Based on recent discussions on mailing list and dh-make-golang and pkg-go-tools about workflows and defaults, and now also in https://go-team.pages.debian.net/workflow-changes.html#wf-2025-01-wrap-and-sort-ast, I think you should update this to default to -ast.

@ottok
Copy link
Contributor

ottok commented Jan 28, 2025

Mailing list has also suggestion about -astbk:

Simo: I believe for most
cases it results in the same output, but it does result in predictable
binary package sort order (except for the first package) which I find
more predictable when paging through debian/control and having some
mental model where to find different parts of a package. Most packages
in Go are simple with just one or two binary packages, so I'm hoping
this is not too difficult to agree on if you already settled for '-tsa'.

@NightTsarina
Copy link
Contributor

So I am in favor of merging this but with -ast as the default.

I also prefer that combination, but it seems there is no consensus yet. I'd say let's merge this as is so we can release and start a thread about only this change.

@NightTsarina NightTsarina merged commit 3e594ae into Debian:master Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants