dh-make-golang make: directly use the user preferred tag specified in "-git_revision" option #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch attempts to fix #226 . |
wlyu2
commented
Nov 27, 2024
|
Does @n-peugnet or @Maytha8 want to review/approve this? |
Maytha8
approved these changes
Jan 14, 2025
|
Closes #226 |
wlyu2
force-pushed
the
fix-use-specified-tag
branch
from
70e9c9c to
4851485
Compare
… "-git_revision" option
When a user specifies a valid tag when using
dh-make-golang make -git_revision {some valid tag}
if there is another tag pointing to the same commit as the specified
tag, then dh-make-golang might use the other tag to determine the
package version.
This patch modifies the behavior of "dh-make-golang make" such that, if
the user specifies a valid tag in "-git_revision" option,
"dh-make-golang make" will always use the specified tag to determine the
upstream package version.
This patch also trivially changes the tests written in version_test.go
so that the tests adjusts to the new function signature of
version.go:pkgVersionFromGit().
Signed-off-by: William Lyu <William.Lyu@windriver.com>
wlyu2
force-pushed
the
fix-use-specified-tag
branch
from
4851485 to
4d16d16
Compare
NightTsarina
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user specifies a valid tag when using
if there is another tag pointing to the same commit as the specified tag, then dh-make-golang might use the other tag to determine the package version.
This patch modifies the behavior of "dh-make-golang make" such that, if the user specifies a valid tag in "-git_revision" option, "dh-make-golang make" will always use the specified tag to determine the upstream package version.
This patch also trivially changes the tests written in version_test.go so that the tests adjusts to the new function signature of version.go:pkgVersionFromGit().