Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compatibility #46

Closed
wants to merge 17 commits into from
Closed

Docker Compatibility #46

wants to merge 17 commits into from

Conversation

Helvio88
Copy link
Contributor

@Helvio88 Helvio88 commented Sep 9, 2023

This set of commits enables TinShop to run on Docker without the need of a config.yaml file mapping.
I am running as a container and without a configuration file. All settings were transported successfully.

According to Viper docs, ENV vars naturally supersede a config file. I mapped all the missing configs on viper.

@Helvio88 Helvio88 mentioned this pull request Sep 9, 2023
Copy link
Contributor Author

@Helvio88 Helvio88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all the needed changes.

@DblK DblK added the invalid This doesn't seem right label Sep 11, 2023
@Helvio88
Copy link
Contributor Author

Please see #49

@Helvio88 Helvio88 closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants