Feature-87: delete_object Refactor & Enhancements
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete_object' for when 'id_type' is 'cid' and add new pytests
…ected code and docstrings
… by sharding the hash of the 'pid', with metadata doc name being the hash of the 'format_id' and update related pytests
…en pid if no 'format_id' is supplied, and add new pytests
…trings, remove boolean return values and update pytests
…'; and clean up code
…tomicity of the process, and to also delete all metadata documents when 'id_type' is pid
…one method '_write_refs_file' and update pytests
…method '_update_refs_file' and update pytests
…ception class thrown in FileHashStore for clarity
…d rail to '_update_refs_file' to ensure duplicate pids are not written when 'update_type' is 'add'
…d '_tag_pid_cid_and_verify_refs_files' and update/add new pytests
…() on fnfe), revise '_verify_hashstor_references' to improve clarity and update affected code
|
Greetings @artntek, when you have a moment - can you please help me review this branch? |
artntek
requested changes
Feb 12, 2024
…ther a cid is in a pid refs file for consistency
…ffected methods and tests
…ffected methods and tests
…d, update affected methods and add new pytest
… found in its expected cid refs file, update affected methods and add new pytest
…locks/synchronization
…in 'retrieve_metadata' to improve clarity
|
I am merging this PR into |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
object_metadataclass with new attributepidto help client streamline the process of passing a pid value.store_metadatato follow new metadata storage design, where all metadata documents for a given pid live in a directory formed by calculating the hash of thepid, with the document name being the hash of thepid + format_idretrieve_metadataanddelete_metadatato account for above changes.delete_metadatawill remove all metadata documents for a given pid if noformat_idis provideddelete_objectUpdates:pidpidreferences files by handling exceptions where relevant_deleteto the file name), adding them to a list, and then iterating over that list to delete files.