chore: emit series/sketches flushed telemetry for aggregation #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/components
rayz
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new telemetry metric --
aggregate_flushed_total-- which tracks the number of series and sketches flushed by the aggregate transform. It additionally contains a new remapped variant of this metric to match thedatadog.agent.aggregator.flushmetric.It remains to be seen if it's necessarily worth locally tallying up the series/sketches totals before incrementing the counters, but I went with the simpler approach for now.
Change Type
How did you test this PR?
Built and ran ADP locally and observed the new metrics when querying the internal telemetry endpoint.
References
N/A