-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add dogstatsd mapper transform #477
Conversation
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Regression Detector (DogStatsD)Regression Detector ResultsRun ID: 2b6634b2-47e4-4487-a6b3-dee61bb8e242 Baseline: 7.63.0-rc.2 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | +0.06 | [-0.10, +0.21] | 1 | |
➖ | dsd_uds_10mb_3k_contexts | ingress throughput | +0.01 | [-0.01, +0.03] | 1 | |
➖ | dsd_uds_1mb_50k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | |
➖ | dsd_uds_512kb_3k_contexts | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | |
➖ | dsd_uds_1mb_3k_contexts_dualship | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | |
➖ | dsd_uds_1mb_3k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | |
➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -0.00 | [-0.00, +0.00] | 1 | |
➖ | dsd_uds_100mb_250k_contexts | ingress throughput | -0.00 | [-0.00, +0.00] | 1 | |
➖ | dsd_uds_40mb_12k_contexts_40_senders | ingress throughput | -0.00 | [-0.00, +0.00] | 1 | |
➖ | dsd_uds_100mb_3k_contexts | ingress throughput | -0.01 | [-0.05, +0.04] | 1 | |
➖ | dsd_uds_500mb_3k_contexts | ingress throughput | -1.36 | [-1.45, -1.28] | 1 | |
➖ | quality_gates_idle_rss | memory utilization | -1.47 | [-1.56, -1.37] | 1 |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | quality_gates_idle_rss | memory_usage | 0/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Regression Detector (Saluki)Regression Detector ResultsRun ID: 2e737c4f-3eb1-48f5-a412-93fbac480a0c Baseline: 00076cf Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | dsd_uds_500mb_3k_contexts | ingress throughput | +1.50 | [+1.34, +1.66] | 1 | |
➖ | quality_gates_idle_rss | memory utilization | +0.28 | [+0.25, +0.31] | 1 | |
➖ | dsd_uds_100mb_3k_contexts | ingress throughput | +0.01 | [-0.05, +0.06] | 1 | |
➖ | dsd_uds_50mb_10k_contexts_no_inlining | ingress throughput | +0.00 | [-0.07, +0.08] | 1 | |
➖ | dsd_uds_40mb_12k_contexts_40_senders | ingress throughput | +0.00 | [-0.03, +0.03] | 1 | |
➖ | dsd_uds_1mb_3k_contexts | ingress throughput | -0.00 | [-0.02, +0.02] | 1 | |
➖ | dsd_uds_1mb_3k_contexts_dualship | ingress throughput | -0.00 | [-0.08, +0.08] | 1 | |
➖ | dsd_uds_50mb_10k_contexts_no_inlining_no_allocs | ingress throughput | -0.00 | [-0.05, +0.05] | 1 | |
➖ | dsd_uds_1mb_50k_contexts | ingress throughput | -0.00 | [-0.01, +0.00] | 1 | |
➖ | dsd_uds_512kb_3k_contexts | ingress throughput | -0.01 | [-0.02, +0.01] | 1 | |
➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.01 | [-0.04, +0.02] | 1 | |
➖ | dsd_uds_100mb_250k_contexts | ingress throughput | -0.01 | [-0.06, +0.04] | 1 | |
➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | -0.52 | [-0.63, -0.41] | 1 | |
➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -1.71 | [-1.96, -1.45] | 1 |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | quality_gates_idle_rss | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector LinksExperiment Result Links
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial feedback from things I immediately saw. I'm still going through the mapping logic itself.
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
882d30c
to
9d2c0e3
Compare
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Signed-off-by: Raymond Zhao <raymond.zhao@datadoghq.com>
Summary
This pr introduces a new transform
dogstatsd_mapper
in order to support the DogstatsD Mapper feature in the datadog agent.Change Type
How did you test this PR?
References
Closes: #163