Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running ADP on macOS, it would immediately crash due to an error coming from
jemalloc
:We previously disabled THP support in
jemalloc
to deal with ballooning RSS but, seemingly,jemalloc
considers it a completely invalid configuration when on macOS instead of just ignoring, thus the abort.This PR simply moves our usage of
jemalloc
to be gated behind#[cfg(target_os = "linux")]
. In the future, it'd be nice to just adjust our compile-timejemalloc
configuration string for macOS to not include thethp:never
bit, but the Cargo configuration file schema doesn't support per-target environment variables, so we don't have an easy way to do so... yet, at least.Change Type
How did you test this PR?
Built ADP locally on both macOS and Linux and ensured they ran correctly without throwing an error at startup.
References
N/A