-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ssi): add target based workload selection #1745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change looks good,
Could you add or update the APM SSI CI helm configuration, so we can validate that the generated manifest is valid: https://github.com/DataDog/helm-charts/blob/main/charts/datadog/ci/apm-single-step-instrumentation-admission-controller-values.yaml
This commit adds support for targets that are available in Cluster Agent 7.64.0.
b4bf26f
to
4a705aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick update
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The median merge time in
|
What this PR does / why we need it:
This change implements Kubernetes SSI | Workload Selection 🎯 which is being released as part of the Datadog Agent in 7.64.0.
Targets can be found here in the cluster agent. The goal is to allow a single operator to be able to configure instrumentation without needing to update any apps or deployments already running there.
Which issue this PR fixes
Special notes for your reviewer:
This change splits out the feature work from #1733 to merge them separately. Also, we will follow up with a future commit to update the examples for instrumentation once the agent has been released.
Tests
I have tested this change using injector-dev using the following scenario:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md